Skip to content

🎨 Palette: Add keyboard instructions and accessible score to Mario game#160

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-a11y-7492972733585240345
Open

🎨 Palette: Add keyboard instructions and accessible score to Mario game#160
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-a11y-7492972733585240345

Conversation

@EiJackGH
Copy link
Copy Markdown
Owner

💡 What

Added an explicitly visible keyboard instructional text block (#instructions) and added screen-reader accessible live regions to the dynamic #score element in the Mario game. Also removed an invalid entry venv from requirements.txt to fix pip installs.

🎯 Why

Custom key bindings in web UIs are undiscoverable without explicit text. Adding a small instructional box immediately teaches users how to interact with the game. In addition, real-time value updates (like score) require aria-live tags to be announced by screen readers, which was previously missing.

📸 Before/After

(See Playwright screenshot from verification phase: instruction text in the top right corner over the blue sky)

♿ Accessibility

  • Added aria-live="polite" to #score to queue and announce score changes to screen readers gracefully.
  • Added aria-hidden="true" to visual instructions so screen readers aren't forced to announce static visual styling rules if not needed.

PR created automatically by Jules for task 7492972733585240345 started by @EiJackGH

- Added visible text block detailing the Space and Up Arrow keys required to jump.
- Added `aria-live="polite"` and `aria-atomic="true"` to the dynamic score counter.
- Cleaned up broken dependency `venv` in requirements.txt.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant